Closed
Conversation
Member
|
I think you can squash the commits together and add an This looks good to me, but my knowledge of the HTTP implementation in core is not too extensive, so /cc @nodejs/http |
Member
|
LGTM, the commits can definitely be squashed but that can be done by whomever lands. |
Contributor
Author
|
Separate PR for a test checking |
Member
|
Landed in 86fdbe0 Many thanks, and I think it’s safe to say that a separate PR for testing this event on client responses would be appreciated! :) |
addaleax
pushed a commit
that referenced
this pull request
Jun 22, 2016
Fixes: #6925 PR-URL: #7270 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
3 tasks
Fishrock123
pushed a commit
that referenced
this pull request
Jun 27, 2016
Fixes: #6925 PR-URL: #7270 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
Fishrock123
pushed a commit
that referenced
this pull request
Jul 5, 2016
Fixes: #6925 PR-URL: #7270 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2016
Fixes: #6925 PR-URL: #7270 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
Fixes: #6925 PR-URL: #7270 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
Fixes: #6925 PR-URL: #7270 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
Fixes: #6925 PR-URL: #7270 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
Fixes: #6925 PR-URL: #7270 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
Fixes: #6925 PR-URL: #7270 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesa test and/or benchmark is included(This PR just adds doc)Affected core subsystem(s)
doc (for HTTP)
Description of change
This pull request follows on #6925 (in which @Fishrock123 and @dougwilson made key appearances) to document the
"aborted"(as opposed to"abort") events emitted on HTTP requests and responses on socket closure by the remote system.A few links from the issue that seem most relevant:
'aborted'from the corresponding response (req.res).'aborted'from requests.'aborted'The last tests the event on
reqfrom the server point of view. I actually don't see a test checking the event from the client API. This test sets a handler on aresfrom anhttp.getcall, but as far as I can tell there's no test verifying its functionality. I can try and cook one up if needed._Be Warned! This is my first PR to Node.js. I reread CONTRIBUTING, but probably screwed something up anyway. Many thanks to team for patience and understanding!_
This PR coming to you live from doc sprint at NodeConf Adventure.